only run get_tests if the tests or release should run

demergent-labs · Sep 6, 2024 · 6346ba4 · 6346ba4
1 parent 7a6828f
commit 6346ba4
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 25 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -8,8 +8,21 @@ env:
     DFX_VERSION: 0.21.0
     NODE_VERSION: 20
 jobs:
-    get-tests:
+    determine-should-release:
         if: ${{ contains(github.head_ref, 'release--') }}
+        name: Determine if this branch should release
+        runs-on: ubuntu-latest
+        outputs:
+            should_release: ${{ steps.determine_should_release.outputs.should_release }}
+        steps:
+            - uses: actions/checkout@v4
+
+            - id: determine_should_release
+              uses: ./.github/actions/should_release
+
+    get-tests:
+        needs: determine-should-release
+        if: ${{ contains(github.head_ref, 'release--') && needs.determine-should-release.outputs.should_release }}
         name: Get tests
         runs-on: ubuntu-latest
         outputs:
@@ -25,18 +38,6 @@ jobs:
                       ./examples
                       ./tests
 
-    determine-should-release:
-        if: ${{ contains(github.head_ref, 'release--') }}
-        name: Determine if this branch should release
-        runs-on: ubuntu-latest
-        outputs:
-            should_release: ${{ steps.determine_should_release.outputs.should_release }}
-        steps:
-            - uses: actions/checkout@v4
-
-            - id: determine_should_release
-              uses: ./.github/actions/should_release
-
     release:
         name: Deploy release
         # Only run this job if it's a release branch. This job will run instead of run-tests and will automatically publish another commit which will be tested

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,8 +16,22 @@ env:
     IS_RELEASE_BRANCH_PR: ${{ contains(github.head_ref, 'release--') }}
     IS_FEATURE_BRANCH_PR: ${{ !contains(github.head_ref, 'release--') }}
 jobs:
+    determine-should-run-tests:
+        name: Determine if tests should run
+        runs-on: ubuntu-latest
+        outputs:
+            # If the branch should release then it shouldn't run tests.
+            should_run_tests: ${{ steps.determine_should_run_tests.outputs.should_release == 'false' }}
+        steps:
+            - uses: actions/checkout@v4
+
+            - id: determine_should_run_tests
+              uses: ./.github/actions/should_release
+
     get-tests:
         name: Get tests
+        needs: determine-should-run-tests
+        if: ${{ needs.determine-should-run-tests.outputs.should_run_tests == 'true' }}
         runs-on: ubuntu-latest
         outputs:
             tests: ${{ steps.get_tests.outputs.tests }}
@@ -43,18 +57,6 @@ jobs:
                          ./tests/property/candid_rpc/functional_api/stable_b_tree_map
                          ') || '' }}
 
-    determine-should-run-tests:
-        name: Determine if tests should run
-        runs-on: ubuntu-latest
-        outputs:
-            # If the branch should release then it shouldn't run tests.
-            should_run_tests: ${{ steps.determine_should_run_tests.outputs.should_release == 'false' }}
-        steps:
-            - uses: actions/checkout@v4
-
-            - id: determine_should_run_tests
-              uses: ./.github/actions/should_release
-
     run-test:
         name: '${{matrix.tests.name}} | ${{matrix.tests.type}} | ${{matrix.tests.syntax}} | ${{matrix.tests.api}} | ${{matrix.azle_source}}'
         needs: