Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rambler.ru #284

Merged
merged 5 commits into from
Mar 21, 2024
Merged

add rambler.ru #284

merged 5 commits into from
Mar 21, 2024

Conversation

WofWca
Copy link
Contributor

@WofWca WofWca commented Mar 16, 2024

For the reviewer: please verify that the servers list makes sense. Maybe Delta Chat tries all those additional ones by itself and they don't need to be specified? What about PLAIN? Will Delta Chat make sure the ones with encryption?

Also FYI I haven't actually tested this data in action, nor have I tried to log in to my Rambler account with Delta Chat.

@WofWca WofWca force-pushed the rambler.ru branch 2 times, most recently from e5ff25e to 29c8248 Compare March 16, 2024 21:18
@iequidoo
Copy link
Contributor

Maybe Delta Chat tries all those additional ones by itself and they don't need to be specified? What about PLAIN? Will Delta Chat make sure the ones with encryption?

Maybe i didn't understand all the questions, but if servers are specified in the server: section, afaiu from the code, they (and only they) are tried in the specified order and security (PLAIN/STARTTLS/SSL) doesn't change that order. So, probably it's better to specify more secure configurations first.

Let's leave it for users to configure manually
@WofWca
Copy link
Contributor Author

WofWca commented Mar 18, 2024

Yes, you answered my questions, thanks.

I put PLAIN at the bottom and added a comment.

But then decided to remove it completely for security.

_providers/rambler.ru.md Outdated Show resolved Hide resolved
@WofWca
Copy link
Contributor Author

WofWca commented Mar 20, 2024

Is it a random CI fail or are my changes bad?

@iequidoo
Copy link
Contributor

iequidoo commented Mar 21, 2024

Error:  imap.rambler.ru:143... [error] SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1000)
Error:  smtp.rambler.ru:587... [error] SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1000)
Error:  smtp.rambler.ru:25... [error] SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1000)
Error:  smtp.rambler.ru:2525... [error] SSLError: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1000)
Error:  imap.rambler.ru:993... [error] abort: socket error: EOF
Error:  smtp.rambler.ru:465... [error] SMTPServerDisconnected: Connection unexpectedly closed: [Errno 104] Connection reset by peer

Maybe some servers need to be just removed from the list.

@WofWca
Copy link
Contributor Author

WofWca commented Mar 21, 2024

Ok, I removed those backup ones.

_providers/rambler.ru.md Outdated Show resolved Hide resolved
TLS should be covered by `socket: SSL` as well
@iequidoo iequidoo merged commit 2c4f202 into deltachat:master Mar 21, 2024
2 checks passed
@iequidoo
Copy link
Contributor

Forgot to squash the commits, it's better to let the PR author to merge...

@WofWca
Copy link
Contributor Author

WofWca commented Mar 22, 2024

I don't have write access to the repo + Idk if I'd prefer to squash myself haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants