Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v1.48 #4323

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Prepare release v1.48 #4323

merged 3 commits into from
Nov 8, 2024

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Nov 8, 2024

No description provided.

@nicodh nicodh changed the title Release v1.48 Prepare release v1.48 Nov 8, 2024
@nicodh nicodh requested a review from r10s November 8, 2024 13:34
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the local offline help will get a downgrade by this PR - probably as ./bin/create-local-help.sh was executed while having ../deltachat-pages/ checked out in an old state - you need to pull there (or, add that to the script, maybe also check if main is checked out)

otherwise, lgtm, also the strings seem to be pulled correctly

@nicodh
Copy link
Contributor Author

nicodh commented Nov 8, 2024

the local offline help will get a downgrade by this PR - probably as ./bin/create-local-help.sh was executed while having ../deltachat-pages/ checked out in an old state - you need to pull there (or, add that to the script, maybe also check if main is checked out)

I was in fresh pulled state in deltachat-pages #86291b98bea add more redirects

Is there another script to be executed in pages before copying to desktop?

@nicodh
Copy link
Contributor Author

nicodh commented Nov 8, 2024

I see the wrong chages now. I will investigate whats wrong...

@r10s
Copy link
Member

r10s commented Nov 8, 2024

I was in fresh pulled state in deltachat-pages #86291b98bea add more redirects

Is there another script to be executed in pages before copying to desktop?

you're right, ./bin/create-local-help.sh creates the offline, assuming HTML-files from ../deltachat-pages/_site are up to date. they are created using bundle exec jekyll build - which may requires some stuff on your computer set up first ... :/

to move forward now - i can do that in a separate PR if you like, things are working for me locally

@nicodh
Copy link
Contributor Author

nicodh commented Nov 8, 2024

i can do that in a separate PR if you like, things are working for me locally

Yes that would help, at least if we want the newest help pages in desktop

@r10s r10s mentioned this pull request Nov 8, 2024
@r10s
Copy link
Member

r10s commented Nov 8, 2024

the last update is only a few weeks ago, but i created #4325 , when we're anyways on that :)

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, much less code also now :)

@nicodh nicodh merged commit 0349c14 into main Nov 8, 2024
10 checks passed
@nicodh nicodh deleted the release-v1.48 branch November 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants