Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: rearrange "realtime webxdc" setting #4316

Merged
merged 1 commit into from
Nov 8, 2024
Merged

improvement: rearrange "realtime webxdc" setting #4316

merged 1 commit into from
Nov 8, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented Nov 5, 2024

Closes #4293

@WofWca WofWca force-pushed the wofwca/move-webxdc-realtime-setting branch from 496e5ca to 965f171 Compare November 5, 2024 13:10
@WofWca WofWca added the ui/ux UI/UX related issues label Nov 5, 2024
@WofWca WofWca marked this pull request as ready for review November 5, 2024 13:10
r10s
r10s approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

the translations need to be pulled before the next release, so that the updated string, that also mention the IP address, get in

@nicodh nicodh merged commit de667c2 into main Nov 8, 2024
10 checks passed
@nicodh nicodh deleted the wofwca/move-webxdc-realtime-setting branch November 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@nicodh nicodh nicodh approved these changes

Assignees
No one assigned
Labels
ui/ux UI/UX related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move webxdc-realtime setting out of experimental
3 participants
@WofWca @nicodh @r10s