fix: Set Config::NotifyAboutWrongPw before saving configuration (#5896) #5967
Conversation
|
Have you checked that during failed configuration device message is not added? During configuration deltachat-core-rust/src/configure.rs Line 423 in f7a705c It adds device message if it fails second time. I guess |
src/configure.rs
Outdated
| .await?; | ||
| let configured_param = configure(self, ¶m).await?; | ||
| if old_addr.is_none() { | ||
| self.set_config_internal(Config::NotifyAboutWrongPw, Some("1")) |
There was a problem hiding this comment.
Why do we need to set it again? Is there a code path that resets NotifyAboutWrongPw during configure()?
There was a problem hiding this comment.
old_addr.is_none() means that configuration is running the first time. So, we need to set NotifyAboutWrongPw because it's 0 by default
|
Maybe |
During initial configuration it's not added, but if the user runs reconfiguration, it's added unfortunately. Because it's not safe to disable |
Let's not complicate the logic and always set `Config::NotifyAboutWrongPw` before saving configuration, better if a wrong password notification is shown once more than not shown at all. It shouldn't be a big problem because reconfiguration is a manual action and isn't done frequently. Also for the same reason reset `Config::NotifyAboutWrongPw` only after a successful addition of the appropriate device message.
iequidoo
force-pushed
the
iequidoo/NotifyAboutWrongPw
branch
from
18011bf
to
3e32980
Compare
iequidoo
changed the title
|
I tried to simplify the logic and now (re)configuration doesn't add device messages about wrong password |
Fix #5896