fix: Retry configuring mvbox on IMAP reconnect if mvbox_move is enabled explicitly #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/move-to-mvbox
branch
from
42ea725
to
0aec3de
Compare
iequidoo
commented
Aug 6, 2024
…ed explicitly If `mvbox_move` isn't enabled explictly, but only by default, better not to retry configuring it to avoid excessive work, but if it's enabled explicitly by the user and actually can't be configured, the user should disable it. But anyway not being able to configure the mvbox doesn't prevent Delta Chat from working just leaving all mail in Inbox.
This makes the code more straightforward in some places and also allows to keep `MvboxMove` unset for chatmail case and thus know that the user hasn't modified it.
iequidoo
force-pushed
the
iequidoo/move-to-mvbox
branch
from
806ed4f
to
ca5227f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
mvbox_moveisn't enabled explictly, but only by default, better not to retry configuring it to avoid excessive work, but if it's enabled explicitly by the user and actually can't be configured, the user should disable it. But anyway not being able to configure the mvbox doesn't prevent Delta Chat from working just leaving all mail in Inbox.