fix: Order of messages if Sentbox is synced before Inbox #5813
+29
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test i added here isn't needed, there's |
iequidoo
force-pushed
the
iequidoo/test_sync_sentbox_then_inbox
branch
from
4ea6d9d
to
ce4be1d
Compare
iequidoo
changed the title
iequidoo
changed the base branch from
main
to
iequidoo/sort-rcvd-outgoing-msgs-down
iequidoo
force-pushed
the
iequidoo/sort-rcvd-outgoing-msgs-down
branch
4 times, most recently
from
3214eb6
to
6c01309
Compare
Base automatically changed from
iequidoo/sort-rcvd-outgoing-msgs-down
to
main
October 15, 2024 00:22
This fixes a Gmail-like scenario when outgoing messages are saved to Sentbox as well and it is fetched before Inbox by chance, by adding a new `OutRcvd` message state for received outgoing messages so that they can mingle with fresh incoming ones and appear after them in chats. As for `OutPending`, `OutDelivered` etc. messages, they are sent locally by the user and there's no need to make them more noticeable even if they are newer.
iequidoo
force-pushed
the
iequidoo/test_sync_sentbox_then_inbox
branch
from
ce4be1d
to
da4a84e
Compare
|
Btw, i think it may be useful to display these outgoing received messages (i.e. from other MUAs/devices) somehow differently e.g. align them to the left as incoming ones. As they still have another brightness (even in Dark mode), it shouldn't be a problem to differ them from incoming messages. May be even useful for shared/community accounts, not sure. CC @adbenitez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects me often because my devices go online/offline independently and i use both to send messages, so often i see my messages wrongly ordered around incoming messages.