Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroh): pass direct addresses from Endpoint to Gossip #5772

Merged
merged 1 commit into from
Jul 13, 2024
Merged

feat(iroh): pass direct addresses from Endpoint to Gossip #5772

merged 1 commit into from
Jul 13, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Jul 12, 2024

No description provided.

@link2xt link2xt requested a review from Septias July 12, 2024 16:49
@link2xt
Copy link
Collaborator Author

link2xt commented Jul 12, 2024

This is essentially extracted from #5602 with a separate function to make the code cleaner and new iroh APIs (endpoints are renamed into direct addresses)

Septias
Septias approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Septias Septias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should at some point think about gossip tear down

@link2xt link2xt merged commit 0f26da4 into main Jul 13, 2024
37 checks passed
@link2xt link2xt deleted the link2xt/gossip-direct-addresses branch July 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Septias Septias Septias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@link2xt @Septias