Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle now unsupported oauth2 #3234

Merged
merged 1 commit into from
Aug 14, 2024
Merged

handle now unsupported oauth2 #3234

merged 1 commit into from
Aug 14, 2024

Conversation

r10s
Copy link
Member

@r10s r10s commented Aug 14, 2024

this PR adds a device message for existing gmail-oauth2 users, telling them how to fix log in problems.

new gmail profiles won't be created using gmail-oauth2

closes #3233

need to update the hints in the provider-db now EDIT: done: deltachat/provider-db#299

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s r10s force-pushed the r10s/remove-gmail-oauth2 branch 4 times, most recently from 0c08a2c to dcc45e7 Compare August 14, 2024 15:49
@r10s r10s requested a review from adbenitez August 14, 2024 15:54
@r10s r10s marked this pull request as ready for review August 14, 2024 15:54
@iequidoo
Copy link
Contributor

Maybe also add this link: https://myaccount.google.com/apppasswords. It pretty hard to find from the Google account settings. I even had to google it :)

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member Author

r10s commented Aug 14, 2024

Maybe also add this link: https://myaccount.google.com/apppasswords. It pretty hard to find from the Google account settings. I even had to google it :)

i followed your device and added that to deltachat/provider-db#299, which is available at "More Info" then; the in-app-box itself does not allow links beside "More Info"

- add a device message for existing profiles potentially using gmail
- reset oauth2 method for existing profiles on opening login screen
- do not offer gmail-oauth2 for new profiles
@r10s r10s merged commit a50d8b9 into main Aug 14, 2024
2 checks passed
@r10s r10s deleted the r10s/remove-gmail-oauth2 branch August 14, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

remove gmail's oauth2
3 participants