Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config-theme #105

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Config-theme #105

wants to merge 15 commits into from

Conversation

MeesoPost
Copy link
Contributor

@MeesoPost MeesoPost commented Nov 13, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signalen-frontend-wcag ❌ Failed (Inspect) Nov 15, 2024 9:43am

@MeesoPost
✨ update config path to use voorbeeld.config.json
2436f38
@MeesoPost
✨ add Utrecht configuration
8f882c5
@MeesoPost
✨ add voorbeeld design tokens as a dev dependency
81a957e
@MeesoPost
✨ update LocaleLayout to use async functions for translations and ser…
34f66e0 
…ver config
@MeesoPost
✨ add configuration for voorbeeld municipality with base URL and head…
761a4a4 
…er settings
@MeesoPost
✨ update AppConfig type to include header and URL properties
e423e7d
@MeesoPost
✨ add svg for voorbeeld municipality
2f63030
@MeesoPost
fix: 🐛 update config files
d295077
@MeesoPost
✨ update i18n configuration to use server config
f7a88a1
@MeesoPost
feat: ✨ update IncidentDescriptionPage to use server config for alert
736ae52
@MeesoPost
feat: ✨ update AppConfig to include contact and i18n properties
9a7b098
@MeesoPost
feat: ♻️ refactor IncidentDescriptionPage to load server config async
2f12dba
@MeesoPost
feat: ✨ add alert configuration
74bdbc6
@MeesoPost
fix: 🐛 handle optional primaryColor in MapDialog component
398d0af 
fix: 🐛 handle optional primaryColor in LocationMap component
@MeesoPost MeesoPost changed the title Feat/translate alert Feat/Config-theme Nov 15, 2024
@MeesoPost MeesoPost changed the title Feat/Config-theme Config-theme Nov 15, 2024
@Robbert
Copy link
Contributor

Robbert commented Nov 18, 2024 •
edited
Loading

Ik ga nog:

  • map marker code aanpassen dat het via design tokens werkt, niet via config
  • i18n teksten weer gedeeltelijk terugplaatsen, alleen de teksten in config.json overblijven die specifiek zijn voor een organisatie
  • en.json en nl.json valideren met nieuwe TypeScript type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeesoPost @Robbert