Feat: show list of features inside Asset Select #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ures are selected
…tween map and list view
# Conflicts: # src/types/form.ts
# Conflicts: # src/store/form_store.ts
Robbert
requested changes
Nov 18, 2024
There was a problem hiding this comment.
2 dingen die gelijk opvallen:
De checkboxes moeten nog in een checkbox group, bijvoorbeeld:
<Fieldset>
<FieldsetLegend><Heading level={1}>Kies de straatverlichting</Heading></FieldsetLegend>
...
</Fieldset>en tweede: de volgorde moet niet veranderen als je dingen checkt. Probeer eens de checkboxes te bedienen met het toetsenbord, dan snap je wat ik bedoel.
| ) ? ( | ||
| <Icon> | ||
| <img src={featureType?.icon.iconUrl} /> | ||
| </Icon> |
There was a problem hiding this comment.
Goed dat je 'm in een <Icon> zet!
|
Nog een ideetje: "Straatverlichting 001" is wel erg lang voor een screen reader. Kunnen we het afkorten tot "Licht 001"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7