Backport includeEndStreamAction in DeltasharingService to branch-0.7 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question @linzhou-db : Should we soak it for some time before we backport? |
linzhou-db
commented
Oct 11, 2024
| @@ -103,14 +114,16 @@ private[spark] class DeltaSharingRestClient( | |||
| numRetries: Int = 10, | |||
| maxRetryDuration: Long = Long.MaxValue, | |||
| sslTrustAll: Boolean = false, | |||
| forStreaming: Boolean = false | |||
| forStreaming: Boolean = false, | |||
| endStreamActionEnabled: Boolean = false | |||
There was a problem hiding this comment.
@chakankardb this is changed to false.
| @@ -30,6 +30,9 @@ object ConfUtils { | |||
| val MAX_RETRY_DURATION_CONF = "spark.delta.sharing.network.maxRetryDuration" | |||
| val MAX_RETRY_DURATION_DEFAULT_MILLIS = 10L * 60L* 1000L /* 10 mins */ | |||
|
|
|||
| val INCLUDE_END_STREAM_ACTION_CONF = "spark.delta.sharing.query.includeEndStreamAction" | |||
| val INCLUDE_END_STREAM_ACTION_DEFAULT = "false" | |||
There was a problem hiding this comment.
@chakankardb this is changed to false.
chakankardb
approved these changes
Oct 11, 2024
|
local tests passed, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport includeEndStreamAction in DeltasharingService to branch-0.7