Use case class ParsedDeltaSharingTablePath as return type for parsePath #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakankardb
reviewed
Sep 8, 2023
| @@ -841,7 +847,7 @@ object DeltaSharingRestClient extends Logging { | |||
| * Parse the user provided path `profile_file#share.schema.share` to | |||
| @@ -74,6 +74,12 @@ trait DeltaSharingClient { | |||
| def getProfileProvider: DeltaSharingProfileProvider = null | |||
| } | |||
|
|
|||
| case class ParsedDeltaSharingTablePath( | |||
There was a problem hiding this comment.
Consider documenting this class.
There was a problem hiding this comment.
@chakankardb added in another PR.
| @@ -65,6 +65,7 @@ private[sharing] class DeltaSharingFileSystem extends FileSystem { | |||
|
|
|||
| override def getUri(): URI = URI.create(s"$SCHEME:///") | |||
|
|
|||
| // delta-sharing:/// | |||
There was a problem hiding this comment.
This comment is not clear. Consider expanding on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case class ParsedDeltaSharingTablePath instead of tuple as return type for parsePath, this is part of #341