CachedTableManager use refresh token to refresh urls #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlenelyu-db
force-pushed
the
refresh-token-spark
branch
from
2765bee
to
7e6d48e
Compare
charlenelyu-db
force-pushed
the
refresh-token-spark
branch
from
7e6d48e
to
d49ed87
Compare
linzhou-db
approved these changes
Sep 1, 2023
client/src/main/scala/org/apache/spark/delta/sharing/PreSignedUrlCache.scala
Outdated
Show resolved
Hide resolved
charlenelyu-db
force-pushed
the
refresh-token-spark
branch
2 times, most recently
from
02ddb7e
to
22b25a3
Compare
charlenelyu-db
force-pushed
the
refresh-token-spark
branch
from
22b25a3
to
a79872d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this link to review incremental changes.
This pr modifies
CachedTableManagerto support refresh token:refresherfunc to takerefreshToken: Option[String], and return(idToUrlMap, minUrlExpiration, newRefreshToken)refreshTokenwill be stored in theCachedTablecachedTable.refresher(cachedTable.refreshToken)to update urls.Note that the above change only applies to latest snapshot queries. For other types of queries,
refreshTokenwill always beNone.This is part 3 of #383.