Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RENG-145 Update config.sh fetch and pass upstream branch to the linux-pkg ant task #296

Conversation

shishaktdlpx
Copy link
Contributor

@shishaktdlpx shishaktdlpx commented Jul 3, 2023

Problem

This PR is a part of the PR (https://github.com/delphix/devops-gate/pull/1406) and https://github.com/delphix/dlpx-app-gate/pull/802.
This change is required to pickup the build.branch automatically.

Solution

Config.sh has been modified where the ant command executes.

Testing Done

07:33:53 Running: ant -Dbuild.branch=develop -DSECRET_DB_USE_JUMPBOX=true -DSECRET_DB_JUMP_BOX_HOST=cred-proxy.ops.delphix.com -DSECRET_DB_JUMP_BOX_USER=ec2-user -DSECRET_DB_JUMP_BOX_PRIVATE_KEY=**** -DSECRET_DB_AWS_ENDPOINT=vpce-064c6c9e8160b1cd9-b3i8sy8a.secretsmanager.us-west-2.vpce.amazonaws.com -Ddockerize=true -DbuildJni=true -DhotfixGenDlpxVersion=14.0.0.0 all-secrets package
(http://selfservice.jenkins-shishaktkumar.dcol2.delphix.com/job/linux-pkg/job/develop/job/build-package/job/virtualization/job/pre-push/3/consoleFull)

@shishaktdlpx shishaktdlpx force-pushed the dlpx/pr/shishaktdlpx/c3083985-9e9e-477c-8d56-e4696e9f2248 branch from 455b55a to bd8fd7f Compare July 3, 2023 11:57
@shishaktdlpx shishaktdlpx requested a review from km4dlpx July 4, 2023 05:10
@shishaktdlpx shishaktdlpx marked this pull request as ready for review July 17, 2023 06:28
packages/virtualization/config.sh Outdated Show resolved Hide resolved
packages/virtualization/config.sh Outdated Show resolved Hide resolved
@shishaktdlpx shishaktdlpx force-pushed the dlpx/pr/shishaktdlpx/c3083985-9e9e-477c-8d56-e4696e9f2248 branch from bd8fd7f to 5f88fbe Compare July 18, 2023 01:54
@shishaktdlpx shishaktdlpx force-pushed the dlpx/pr/shishaktdlpx/c3083985-9e9e-477c-8d56-e4696e9f2248 branch from 5f88fbe to 7422922 Compare July 18, 2023 15:05
Copy link
Contributor

@palash-gandhi palash-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retest your final diff

@shishaktdlpx shishaktdlpx merged commit 68c8b0a into develop Jul 19, 2023
10 checks passed
@shishaktdlpx shishaktdlpx deleted the dlpx/pr/shishaktdlpx/c3083985-9e9e-477c-8d56-e4696e9f2248 branch July 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants