Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[One pull request to rule them all] Loading properties of plugin + encoding bug + passing parameter to message #17

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

anthonyMoreira
Copy link

@anthonyMoreira anthonyMoreira commented Jul 20, 2017

It's a big pull request integrating works from other pull request that has never been merged.
Issue fixed :
#13
#5
#15
#11

The main problem we had with this plugin is that it was unable to search for properties in plugins. To resolve that we did two things :

  • In build mode, a special gradle task getRuntimeClasspath retrieves all of the dependency path and set a system property with all the paths. Later in I18nProcessor, we uses the different paths to check for additional properties.
  • In dev mode, we use Holders.pluginManager to retrieve the properties from the plugin
    Also we saw that the current system only allowed 1 ressource to be fetched for one properties which isn't correct in case you have many plugins with properties of the same name (example : messages.properties ).
    Overrall we improved on previous pull request even if it's still kind of hackish

We upgraded the grails version to 3.2.11 due to incompatibility problem with the gradle api.

We created a plugin to automatically apply the task getRuntimeClasspath before assetCompile

@anthonyMoreira anthonyMoreira changed the title Loading properties of plugin + encoding file bug + passing parameter to message Loading properties of plugin + encoding bug + passing parameter to message Jul 20, 2017
@anthonyMoreira anthonyMoreira changed the title Loading properties of plugin + encoding bug + passing parameter to message Loading properties of plugin + encoding bug + passing parameter to message [One pull request to rule them all] Jul 24, 2017
@anthonyMoreira anthonyMoreira changed the title Loading properties of plugin + encoding bug + passing parameter to message [One pull request to rule them all] [One pull request to rule them all] Loading properties of plugin + encoding bug + passing parameter to message Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant