-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[One pull request to rule them all] Loading properties of plugin + encoding bug + passing parameter to message #17
Open
anthonyMoreira
wants to merge
19
commits into
dellermann:master
Choose a base branch
from
webbfontaine:load-plugin-messages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: build.gradle
anthonyMoreira
changed the title
Loading properties of plugin + encoding file bug + passing parameter to message
Loading properties of plugin + encoding bug + passing parameter to message
Jul 20, 2017
anthonyMoreira
changed the title
Loading properties of plugin + encoding bug + passing parameter to message
Loading properties of plugin + encoding bug + passing parameter to message [One pull request to rule them all]
Jul 24, 2017
anthonyMoreira
changed the title
Loading properties of plugin + encoding bug + passing parameter to message [One pull request to rule them all]
[One pull request to rule them all] Loading properties of plugin + encoding bug + passing parameter to message
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a big pull request integrating works from other pull request that has never been merged.
Issue fixed :
#13
#5
#15
#11
The main problem we had with this plugin is that it was unable to search for properties in plugins. To resolve that we did two things :
Also we saw that the current system only allowed 1 ressource to be fetched for one properties which isn't correct in case you have many plugins with properties of the same name (example : messages.properties ).
Overrall we improved on previous pull request even if it's still kind of hackish
We upgraded the grails version to 3.2.11 due to incompatibility problem with the gradle api.
We created a plugin to automatically apply the task getRuntimeClasspath before assetCompile