Added features / redesign plugin #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merged commit from mugren
…esource bundles are, i.e.: messages_en.i18n inherits from messages.i18n. * Added support for loading messages bundles from plugins * Added support for regexp to select keys from the source properties file. * Removed support for @import _ (not needed anymore). * messages_nl.i18n loads messages from messages_nl.properties and from messages.properties. (They are merged before selecting keys).
* Updated grails version * Added i18n.js javascript to allow more advanced formatting on the client. * Added i18n usage to README.MD
|
Thank you for your contributions. I'll revise it soon… |
…ble, changed to simply checking for Holders.pluginManager not null. Added sorted output for keys.
|
i see this PR is from may and hasnt been updated. anyone opposed to me just rolling it into the official asset-pipeline github repository |
|
@davydotcom please do. I think it makes more sense being a part of the overall asset-pipeline ecosystem anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commits and README.MD for changes.
There are breaking changes in this PR, that's why I've changed the version to 2.1.
I think the changes are useful, I have them implemented on my project.
Solves:
#4
#11
#12