-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling SDC dependency for NFS Volume Provisioning #330
Conversation
72751c8
to
30b74b4
Compare
go 1.22 | ||
go 1.22.0 | ||
|
||
toolchain go1.22.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to define a toolchain here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure on this, I'd have to defer this to Harshita.
Branch needs to be rebased with latest from main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and all comments were addressed.
* fix UT, update to latest goscaleio
8012a23
to
b00432b
Compare
Description
The below changes were made a part of this PR.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
UT code coverage:
coverage: 90.0% of statements
Attachments: cert-csi logs for the above 2 cases.
cert-csi-NFS-sdc-installed.txt
cert-csi-NFS-sdc-NOT-installed.txt
cert-csi-XFS-sdc-installed.txt
In addition to above, also ran the following on clusters with SDC installed and not installed: