Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show logs of spin module #168

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

0xE282B0
Copy link
Contributor

Add trigger-hook to forward spin module stdout.

@jpflueger, @voigt could you check if it fixes the problem for you as well?
closes #123

Signed-off-by: Sven Pfennig <[email protected]>
@voigt
Copy link

voigt commented Oct 16, 2023

Will look into it asap.

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mossaka
Copy link
Member

Mossaka commented Oct 21, 2023

It looks like the tests are failing. Trying it again...

@Mossaka Mossaka merged commit 50dd14f into deislabs:main Oct 21, 2023
20 checks passed
@jprendes
Copy link
Contributor

I fail to see how StdioTriggerHook is used.
I don't see it being constructed anywhere.

@0xE282B0 is there any commit missing here?

@0xE282B0
Copy link
Contributor Author

@jprendes 🤣 It seems that you are the firs one who is taking a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No print output from within Spin app
4 participants