Refactor cross container and bump runwasi #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
force-pushed
the
refactor-cross
branch
from
4867c67
to
1fd2964
Compare
jprendes
changed the title
jprendes
changed the title
Mossaka
reviewed
Oct 21, 2023
jprendes
force-pushed
the
refactor-cross
branch
from
04a1abb
to
b908d78
Compare
|
rebased |
jprendes
force-pushed
the
refactor-cross
branch
from
b908d78
to
ec4a8a3
Compare
jprendes
changed the title
jprendes
force-pushed
the
refactor-cross
branch
3 times, most recently
from
8f7c94c
to
5a8cc73
Compare
|
It looks like enabling seccomp is messing with the CI tests. |
jprendes
force-pushed
the
refactor-cross
branch
2 times, most recently
from
343fef5
to
de051f6
Compare
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
force-pushed
the
refactor-cross
branch
from
de051f6
to
746148b
Compare
It turns out it was a bug in upstream Everything should work fine with |
|
Thanks, @jprendes. Merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and unifies the
Dockerfiles used bycross-rsfor the different shims.As part of the refactor:
runwasiis bumped to latest commitlibseccompis made available in the container, as it's not required byrunwasiWe also accidentally lost cgroups v1 support with #148. This PR re-enables it by bumping
runwasi(which now enables it unconditionally).Note:
There are failures running the shims when seccomp is enabled.-> fixed by bumping runwasi to include youki's UB fix.