feat: integrate youki to the spin shim #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
this commits deletes the runtime config path which isn't being used in the spin trigger. It also removes some commented lines of the stdio becuase now in the cgroup all the ios are handled by the prepare_stdio function and spin can just use the default stdio wiring up wasmtime. As a consequence of it, we can also remove podio.rs Signed-off-by: jiaxiao zhou <[email protected]>
This commits removes the command from workloads yamls. This is because now the spin image has an explicit entrypoint pointing to a executable wasm module, which is required by the libcontainer. I am expecting that this will go away with futuer iteration of the libcontainer Signed-off-by: jiaxiao zhou <[email protected]>
Mossaka
force-pushed
the
youki-spin
branch
2 times, most recently
from
531b668
to
5f8df2c
Compare
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
|
wooo the pipelines succeed! |
|
I am going to merge this in if there are no other comments. One breaking thing from the user side is that they no longer can just do This isn't super desired and I expect that this will go away once this issue closes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates youki's
libcontainercrate to the spin shim.