fix(cleaner): remove the usage of watch api #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
remove the usage of watch api and instead get the namespaces to know which apps are deleted because the watch api is flaky and also the channel gets closed too often kubernetes/kubernetes#8700
Issue(s) that this PR Closes
closes #287
Associated End To End Test PR(s)
deis/workflow-e2e#182
Associated Documentation PR(s)
Associated Design Document(s)
Testing Instructions
Please provide a detailed list for how to test the changes in this PR.
Pull Request Hygiene TODOs
Please make sure the below checklist is complete.