Remove one promotion per product rule limitation. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was earlier proposed in StemboltHQ#3 but closed because it seemed dangerous. After looking more carefully at the issue involved I think we can do this and it will help make promotions much more flexible.
|
Are there any side effects of this change that you can see from this change in basecamp? Maybe it would be nice to have a spec for this so we can see that the code has transcended this limitation. |
|
I'm just going to merge this now, it's causing a lot of problems. |
shioyama
added a commit
that referenced
this pull request
Oct 7, 2015
…rule Remove one promotion per product rule limitation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was earlier proposed in StemboltHQ#3 but closed because
it seemed dangerous. After looking more carefully at the issue involved
I think we can do this and it will help make promotions much more
flexible.