Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KOMOJU Plugin for WooCommerce Cart Checkout Block & HPOS #119

Merged
merged 10 commits into from
Jul 21, 2024

Conversation

Dinwy
Copy link
Collaborator

@Dinwy Dinwy commented Jul 17, 2024

Description:

This PR updates the KOMOJU Payments plugin to ensure compatibility with WooCommerce's Ceckout block & High-Performance Order Storage (HPOS) feature. The following changes have been made:

Compatibility Declaration:

  • Added code to declare compatibility with WooCommerce's 'cart_checkout_blocks' and 'custom_order_tables' features.

Payment Method Data Handling:

  • Added a check to ensure the plugin does not operate on the 'order-received' endpoint to avoid unnecessary session creation.

Order Meta Data Handling:

  • Replaced update_post_meta calls with WC_Order's update_meta_data and save methods to ensure compatibility with HPOS.
  • Updated the save_komoju_meta_data function to use update_meta_data instead of update_post_meta.

Fix timing issue in the test

  • There was timing issue in cypress that it was testing without signed in correctly. So, I adjusted the process about how to sign in.

After this get merged, I will update version to 3.1.4 and will publish it.
If you have any concerns or questions please let me know!

@Dinwy Dinwy force-pushed the update/declareCompatibility branch from bd9d698 to 719add5 Compare July 17, 2024 11:04
@Dinwy Dinwy changed the title WIP: Update KOMOJU Plugin for WooCommerce Cart Checkout Block & HPOS Update KOMOJU Plugin for WooCommerce Cart Checkout Block & HPOS Jul 17, 2024
Copy link
Contributor

@makotom makotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your relentless effort to fix these issues!

@Dinwy Dinwy merged commit 9b04920 into master Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants