Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing test in Cypress & PHP lint #113

Closed
wants to merge 6 commits into from

Conversation

Dinwy
Copy link
Collaborator

@Dinwy Dinwy commented May 17, 2024

Overview

This pull request includes onfiguration updates to enhance the maintainability and functionality of the Komoju WooCommerce plugin.

Key Changes

  1. PHP CS Fixer Adjustments:
  • Updated the .php-cs-fixer.dist configuration to reflect the latest practices and compatibility with PHP CS Fixer version 3.57.1.

    • Renamed psr4 fixer to psr_autoloading to comply with deprecated rules.
    • Adjusted the yoda_style fixer from null to false to avoid configuration errors.
  • GitHub Actions Workflow Update:

    • Updated the lint.yml workflow file to explicitly specify the .php-cs-fixer.dist configuration file when running PHP CS Fixer.
  1. Code Style Enforcement:
  • Update PHP style by running php-cs-lint
  1. Cypress E2E Tests:
  • Updated Cypress end-to-end test scripts to refine testing processes and adapted scripts to changes in the UI elements.
  • Komoju module test has been removed because with new WooCommerce's checkout block, this payment method is no longer supported.
    image

Conclusion

All changes have been tested locally to ensure that they meet our coding standards without breaking existing functionality.

@rp-dgc rp-dgc mentioned this pull request May 20, 2024
@Dinwy Dinwy force-pushed the update/failingTests branch 4 times, most recently from 533f260 to 7de4fe1 Compare May 22, 2024 05:07
@Dinwy
Copy link
Collaborator Author

Dinwy commented May 22, 2024

This was merged into: #114

@Dinwy Dinwy closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants