Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: upgrade to datadog v2 #7

Merged
merged 8 commits into from
Aug 6, 2024
Merged

feat!: upgrade to datadog v2 #7

merged 8 commits into from
Aug 6, 2024

Conversation

dimasdanz
Copy link
Contributor

@dimasdanz dimasdanz commented Aug 6, 2024 •
edited
Loading

Changes:

  1. Upgrade to datadog v2
  2. Add some tests to cover tracing.rb
  3. Disable Metric rubocop

@dimasdanz dimasdanz self-assigned this Aug 6, 2024
@dimasdanz dimasdanz requested a review from sulami August 6, 2024 00:41
@dimasdanz
Copy link
Contributor Author

running this specific branch on hats actions here https://github.com/degica/hats/pull/23090

@dimasdanz
Copy link
Contributor Author

all checks are successful here https://github.com/degica/hats/pull/23090

@dimasdanz dimasdanz requested a review from sulami August 6, 2024 02:03
sulami
sulami approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@sulami sulami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked over at https://app.datadoghq.com/apm/traces?query=env%3Astaging%20version%3A%22feat%2Fupgrade-datadog-bf06c1a1779db353bfb57c05fc5ea371aff8d972%22 as well, and it looks like we're getting data alright 🚀

@dimasdanz dimasdanz merged commit abfb642 into main Aug 6, 2024
3 checks passed
@sulami sulami deleted the feat/upgrade-datadog branch August 6, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulami sulami sulami approved these changes

Assignees

@dimasdanz dimasdanz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimasdanz @sulami