Lots of tracing changes to make things easier to understand #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sulami
commented
Jan 18, 2024
sulami
commented
- Instrument rake tasks
- Split HTTP requests by domain instead of lumping them into one "service"
- Split DB queries into different databases
- Treat Active Record as part of the app, not the DB
- Allow overriding config values
- Remove the Rails dependency
- Fallback to "unknown" instead of nil for unset required tags
This way we don't have a single "Faraday" service, but one service per domain we connect to, which maps much better to what a service is.
Ideally we'd use the proper database name, but this is a zero-configuration method that should be at least useful.
I don't think we actually need this.
zuccamia
reviewed
Jan 19, 2024
| @@ -57,6 +64,10 @@ def statsd_port | |||
| def tracing_port | |||
| datadog_agent_uri&.port || 8126 | |||
| end | |||
|
|
|||
| def inspect | |||
| "DegicaDatadog::Config<enabled?=#{!!enabled?} service=#{service} version=#{version} environment=#{environment} repository_url=#{repository_url} datadog_agent_host=#{datadog_agent_host} statsd_port=#{statsd_port} tracing_port=#{tracing_port}>" # rubocop:disable Layout/LineLength | |||
There was a problem hiding this comment.
Just out of curiosity, where on DD will we be able to see this?
There was a problem hiding this comment.
This won't be on DD, but it's what you get when you open up an irb and check out DegicaDatadog::Config. I ended up checking a lot of these values over and over while tweaking settings, so having them all easily accessible might help in the future when we're debugging something like data not coming through or being wrongly tagged.
zuccamia
reviewed
Jan 19, 2024
Comment on lines
+17
to
+22
| DegicaDatadog::Config.init( | ||
| service_name: "hats", | ||
| version: "1.3", | ||
| environment: "staging", | ||
| repository_url: "github.com/degica/not-hats" | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.