Only update browser state on pjax success #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did the failing tests manually and the behavior is what I'd expect after a failed request (both when returning true & false). |
|
Please stop all patch
…On Jan 8, 2017 00:10, "nickelfault" ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#660
Commit Summary
- Only update browser state on pjax success
File Changes
- *M* jquery.pjax.js
<https://github.com/defunkt/jquery-pjax/pull/660/files#diff-0> (16)
Patch Links:
- https://github.com/defunkt/jquery-pjax/pull/660.patch
- https://github.com/defunkt/jquery-pjax/pull/660.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#660>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AInlWMnm_1wdOxArNsVNiGTIp0IvWSbwks5rP_9CgaJpZM4Ldhx5>
.
|
|
I'm not sure what you mean by "please stop all patch"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ajax request fails and you return false in the pjax:error event, I don't think pushState() should still be executed. When this happens you end up with an incorrect URL in the address bar. In my case, on a failure I display an alert to the user (404 not found, etc). In this case the user ends up with an inconsistent state, they see different content than the URL should provide, and if they refresh the page they'd get a whole new set of content.