Event "pjax:beforeApply" to update options #550

SamyPesse · 2015-08-04T13:17:58Z

This PR is a simple proposal to add a pjax:beforeApply event, which let us change the container (and some others options) according to the content returned by the AJAX request.

I'm using this to load content into different containers: main page and modals. A modal is just some content displayed on top of the main page without changing the page's url. So we have a static website that looks dynamic by remotely loading modals.

I understand that it's probably not an intended usage of pjax.

Example:

<body>
    <div id="pjax-container"></div>
    <div id="modals-container"></div>
</body>

$(document).pjax('a', '#pjax-container')
.on('pjax:beforeApply', function(e, xhr, content, updateOptions) {
    var isModal = xhr.getResponseHeader('X-PJAX-IsModal');

    if (isModal) {
        updateOptions({
            container: "#modals-container",
            push: false
        });
    }
});

Current solution: bind with different options

The current solution is to apply pjax according to an attribute:

$(document).pjax('a[data-pjax!=modal]', '#pjax-container');
$(document).pjax('a[data-pjax=modal]', '#pjax-modal', {
    push: false
});

The issue with this solution is to ensure that all links have the correct target (data-pjax). Also it doesn't work for submitting a form in a modal (data-pjax=modal) that causes a redirection for the main page (the redirected content will be displayed in the modal container).

SamyPesse added 3 commits August 4, 2015 12:52

Add event "pjax:updateOptions" to update options according to content

b171128

Change event name to "beforeApply"

460260b

Add xhr to pjax:beforeApply event

b722de5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event "pjax:beforeApply" to update options #550

Event "pjax:beforeApply" to update options #550

SamyPesse commented Aug 4, 2015

Event "pjax:beforeApply" to update options #550

Are you sure you want to change the base?

Event "pjax:beforeApply" to update options #550

Conversation

SamyPesse commented Aug 4, 2015

Example:

Current solution: bind with different options