Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dev mode parameter for methods that can use it #43

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Added dev mode parameter for methods that can use it #43

merged 3 commits into from
Apr 3, 2024

Conversation

rishsriv
Copy link
Member

@rishsriv rishsriv commented Apr 1, 2024

This will make more sense with a new PR that's coming up on the backend repo! For now, adding this param will not have any effect

wongjingping
wongjingping approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these! Should we also add the dev mode to update_golden_queries, get_golden_queries, delete_golden_queries as well?

@rishsriv
Copy link
Member Author

rishsriv commented Apr 1, 2024

Good point – will add in a bit!

@rishsriv
Copy link
Member Author

rishsriv commented Apr 3, 2024

@wongjingping - will add those later, merging for now!

@rishsriv rishsriv merged commit b3f5b77 into main Apr 3, 2024
2 checks passed
@rishsriv rishsriv deleted the rishabh/dev-mode branch April 3, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongjingping wongjingping wongjingping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishsriv @wongjingping