Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made database scanning optional and prompted users #24

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Made database scanning optional and prompted users #24

merged 3 commits into from
Jan 12, 2024

Conversation

rishsriv
Copy link
Member

Additionally, refactored the generate_db_schema function to take in scan and bool parameters, to make it more extendable.

wongjingping
wongjingping approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@wongjingping wongjingping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates!

@wongjingping wongjingping merged commit d4a37e7 into main Jan 12, 2024
2 checks passed
@wongjingping wongjingping deleted the rishabh/optional-scan branch January 12, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongjingping wongjingping wongjingping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishsriv @wongjingping