Fix feedback logging #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongjingping
force-pushed
the
jp/feedback
branch
from
7fb081a
to
295b967
Compare
- query.py: we exclude connection errors from logging - cli.py: refactor feedback solicitation after query generation to use a separate function `util.get_feedback` - remove an unused function - update requirements.txt - add tests - streamline workflows
wongjingping
force-pushed
the
jp/feedback
branch
from
295b967
to
316f54b
Compare
rishsriv
reviewed
Jan 11, 2024
| @@ -196,3 +202,10 @@ def execute_query( | |||
| write_logs(str(e)) | |||
| retries -= 1 | |||
| raise Exception(err_msg) | |||
|
|
|||
|
|
|||
| def is_connection_error(err_msg: str) -> bool: | |||
There was a problem hiding this comment.
Thank you! This works very well for Postgres, though may not work as well for Snowflake and other flavors
250001 (08001): Failed to connect to DB. Verify the account name is correct: [`REDACTED`/). HTTP 403: Forbidden
MySQL
1045 (28000): Access denied for user 'root'@'localhost' (using password: YES)
etc. Can fix later, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for feedback logging DEF-102:
util.get_feedback