-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configurable bot accounts and gitlab license #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwyles
changed the title
feat: add configurable bot accounts
feat: add configurable bot accounts and gitlab license
Oct 2, 2024
Racer159
requested changes
Oct 2, 2024
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Racer159
requested changes
Oct 2, 2024
Co-authored-by: Wayne Starr <[email protected]>
Racer159
requested changes
Oct 2, 2024
Racer159
approved these changes
Oct 3, 2024
ericwyles
pushed a commit
that referenced
this pull request
Oct 3, 2024
🤖 I have created a release *beep* *boop* --- ## [17.2.7-uds.2](v17.2.7-uds.1...v17.2.7-uds.2) (2024-10-03) ### Features * add configurable bot accounts and gitlab license ([#206](#206)) ([0e22c21](0e22c21)) ### Miscellaneous * update admin tasks for consistency ([#202](#202)) ([b376718](b376718)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to configure bot accounts when deploying gitlab. For each account it will create the account in gitlab, create a pat for the account, and store the pat in a secret. If using gitlab premium or ultimate, it will create service accounts instead of regular user accounts.
Also added the ability to set a gitlab license in the config chart since that was needed for local testing on deploy. Tested that locally with a trial license. Will add screenshot of that test result in comments.
Related Issue
Fixes #205
Fixes #207
Type of change
Checklist before merging