Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable bot accounts and gitlab license #206

Merged
merged 25 commits into from
Oct 3, 2024

Conversation

ericwyles
Copy link
Contributor

@ericwyles ericwyles commented Sep 30, 2024

Description

Add ability to configure bot accounts when deploying gitlab. For each account it will create the account in gitlab, create a pat for the account, and store the pat in a secret. If using gitlab premium or ultimate, it will create service accounts instead of regular user accounts.

Also added the ability to set a gitlab license in the config chart since that was needed for local testing on deploy. Tested that locally with a trial license. Will add screenshot of that test result in comments.

Related Issue

Fixes #205
Fixes #207

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@ericwyles
Copy link
Contributor Author

Job output when using trial license for ultimate

image

@ericwyles
Copy link
Contributor Author

And the same job if no license is given in the config chart:

image

@ericwyles ericwyles changed the title feat: add configurable bot accounts feat: add configurable bot accounts and gitlab license Oct 2, 2024
@ericwyles ericwyles marked this pull request as ready for review October 2, 2024 01:33
@ericwyles ericwyles requested a review from a team as a code owner October 2, 2024 01:33
charts/config/values.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-account-role.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-account-role.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/values.yaml Outdated Show resolved Hide resolved
charts/settings/values.yaml Outdated Show resolved Hide resolved
docs/configuration.md Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
charts/settings/templates/bot-account-role.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/values.yaml Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
k3d-bak Outdated Show resolved Hide resolved
tasks/test.yaml Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
charts/settings/templates/bot-accounts-job.yaml Outdated Show resolved Hide resolved
@ericwyles ericwyles merged commit 0e22c21 into main Oct 3, 2024
12 checks passed
@ericwyles ericwyles deleted the ewyles/bot-accounts branch October 3, 2024 17:18
ericwyles pushed a commit that referenced this pull request Oct 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[17.2.7-uds.2](v17.2.7-uds.1...v17.2.7-uds.2)
(2024-10-03)


### Features

* add configurable bot accounts and gitlab license
([#206](#206))
([0e22c21](0e22c21))


### Miscellaneous

* update admin tasks for consistency
([#202](#202))
([b376718](b376718))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set gitlab license Add ability to create gitlab bot accounts
2 participants