Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

feat: add initial lula lint in OSCAL creation and lula lint action #665

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CloudBeard
Copy link
Contributor

Added initial Lula Lint Action.

Checkouts code, setups Lula, and Lints the OSCAL file to ensure it is a schema compliant file.

Only triggers on changes to the OSCAL file.

Added Lula Lint inside of OSCAL generation to lint files at time of creation. This covers scenarios where OSCAL is created in CI from Component Generator or out of line updates.

Copy link
Collaborator

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this in general LGTM - not completely following why the workflow is in two spots though, could you explain that portion? I might just be having trouble following the PR description.

@CloudBeard
Copy link
Contributor Author

@mjnagel the lula-lint action would catch any changes to the OSCAL that could happen outside of the component generator. Its not a necessity where its included in the in the component generator portion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants