Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from blueprints and decouple bastion requirements #35

Merged
merged 9 commits into from
Aug 17, 2023

Conversation

zack-is-cool
Copy link
Member

@zack-is-cool zack-is-cool commented Aug 14, 2023

closes https://github.com/defenseunicorns/terraform-aws-uds-eks/issues/26
closes https://github.com/defenseunicorns/terraform-aws-uds-eks/issues/34

BEGIN_COMMIT_OVERRIDE
feat!: refactors away from terraform-aws-eks-blueprints to terraform-aws-eks-blueprints-addons for the terraform-aws-eks-blueprints v5 release https://github.com/defenseunicorns/terraform-aws-uds-eks/pull/35

feat: remove bastion dependencies from the eks module https://github.com/defenseunicorns/terraform-aws-uds-eks/pull/35
END_COMMIT_OVERRIDE

@zack-is-cool zack-is-cool requested review from a team as code owners August 14, 2023 22:35
@zack-is-cool zack-is-cool marked this pull request as draft August 14, 2023 22:37
@zack-is-cool
Copy link
Member Author

zack-is-cool commented Aug 14, 2023

it looks like they removed calico from https://github.com/aws-ia/terraform-aws-eks-blueprints-addons.git ... so we will need to figure out how to apply that

probably just call https://github.com/aws-ia/terraform-aws-eks-blueprints-addon.git ourselves

@zack-is-cool zack-is-cool force-pushed the feature/issue-26/blueprints-v5-migration branch from 2b7bb0b to 05de15a Compare August 16, 2023 17:04
@zack-is-cool zack-is-cool marked this pull request as ready for review August 17, 2023 00:10
@zack-is-cool
Copy link
Member Author

Copy link

@brianrexrode brianrexrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zack-is-cool zack-is-cool merged commit 58fee99 into main Aug 17, 2023
@zack-is-cool zack-is-cool deleted the feature/issue-26/blueprints-v5-migration branch August 17, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants