chore: pin setuptools_scm in the metrics extra
#5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
added
the
ignore-for-release-notes
Pull Request Test Coverage Report for Build 6314420841
💛 - Coveralls |
masci
reviewed
Sep 26, 2023
| @@ -197,6 +197,9 @@ onnx-gpu = [ | |||
| metrics = [ # for metrics | |||
| "scipy>=1.3.2", | |||
| "rapidfuzz>=2.0.15,<2.8.0", # FIXME https://github.com/deepset-ai/haystack/pull/3199 | |||
| # Pin setuptools_scm to prevent errors in Windows tests while installing seqeval | |||
| # https://github.com/deepset-ai/haystack/issues/5889 | |||
| "setuptools_scm<8.0", | |||
There was a problem hiding this comment.
If you know this is only for Windows you can add ; platform_system == 'Windows'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
seqevalinstallation #5889Proposed Changes:
Pin
setuptools_scm<8.0in themetricsextra to avoid errors in Windows tests while installingseqevalHow did you test it?
It is an attempt and I could not test it
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.