Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add async support to InMemoryBM25Retriever and InMemoryEmbeddingRetriever #138

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Nov 22, 2024

Related Issues

Proposed Changes:

Add async support to InMemoryBM25Retriever and InMemoryEmbeddingRetriever. And a fly-by doc fix.

How did you test it?

Integration tests

Checklist

@shadeMe shadeMe requested a review from a team as a code owner November 22, 2024 13:16
@shadeMe shadeMe requested review from mpangrazzi and silvanocerza and removed request for a team and mpangrazzi November 22, 2024 13:16
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11973374927

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 81.929%

Files with Coverage Reduction New Missed Lines %
components/tools/openapi/_schema_conversion.py 3 88.79%
Totals Coverage Status
Change from base Build 11963918591: 0.03%
Covered Lines: 2344
Relevant Lines: 2861

💛 - Coveralls

@shadeMe
Copy link
Contributor Author

shadeMe commented Nov 22, 2024

Failing integration tests are unrelated.

@shadeMe shadeMe merged commit 6b93e7a into deepset-ai:main Nov 25, 2024
8 of 10 checks passed
@shadeMe shadeMe deleted the feat/async-inmemory-retrievers branch November 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants