Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ensure_ascii when dumping to json tool responses #134

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Set ensure_ascii=False when dumping to JSON tool or function calls, this way special chars like emojis are not lost.

How did you test it?

I tested manually.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza self-assigned this Nov 19, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner November 19, 2024 16:56
@silvanocerza silvanocerza requested review from shadeMe and removed request for a team November 19, 2024 16:56
@silvanocerza silvanocerza changed the title Disable ensure_ascii when dumping to json tool responses Disable ensure_ascii when dumping to json tool responses Nov 19, 2024
@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11917903376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 89.551%

Files with Coverage Reduction New Missed Lines %
components/tools/tool_invoker.py 1 93.67%
components/tools/openai/function_caller.py 2 92.86%
components/generators/chat/openai.py 3 97.16%
components/tools/openapi/openapi_tool.py 3 58.43%
Totals Coverage Status
Change from base Build 11903548008: 0.0%
Covered Lines: 1894
Relevant Lines: 2115

💛 - Coveralls

@silvanocerza silvanocerza merged commit 1b228a4 into main Nov 20, 2024
5 of 8 checks passed
@silvanocerza silvanocerza deleted the fix-json-dumps branch November 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

experimental: OpenAIFunctionCaller string parsing
3 participants