Code

Slot Improvements#411

Code

Open

ZergLev wants to merge 33 commits intodevdeeppavlov/chatsky:devfrom feat/slot_improvementsdeeppavlov/chatsky:feat/slot_improvementsCopy head branch name to clipboard

+1,081-542

Commits

Commits on Nov 22, 2024

• added SlotValueEquals, drafted RegexpGroupSlot, formatting a GroupSlot with an f-string, moved derivative slots into a different file

  ZergLev

  committed
  868f5ef

• removed checking for funder names in slot names for GroupSlot + lint

  ZergLev

  committed
  80500f6

Commits on Nov 25, 2024

• moved SlotManager into it's own file, ValueSlot back into base_slots, changed some imports

  ZergLev

  committed
  03fed9e

• changed RegexpGroupSlot to use regex only once, updated slot imports across the codebase (to the new file structure)

  ZergLev

  committed
  eb0a528

• renamed 'success_only' to 'save_on_failure'

  ZergLev

  committed
  036cf07

• lint

  ZergLev

  committed
  14c651c

Commits on Nov 27, 2024

• refactored RegexGroupSlot, changed description for it

  ZergLev

  committed
  306cb84

• refactor: moved Extracted slots and GroupSlot into base_slots.py

  ZergLev

  committed
  36a3d2b

• refactor: updated slot imports across the codebase (according to the new slots' file structure)

  ZergLev

  committed
  c18d01a

• drafted pipeline.yaml test files updates, test_script_parsing's TestImportPipeline tests all pass

  ZergLev

  committed
  a49984b

Commits on Dec 2, 2024

• renamed slots.py -> standard_slots.py

  ZergLev

  committed
  c0ee05a

• drafting dictionary validator for GorupSlot (unfinished)

  ZergLev

  committed
  ad6d906

• drafted model_validator for GroupSlot

  ZergLev

  committed
  4e0215e

• reverted pipeline.yml changes

  ZergLev

  committed
  fe2a382

Commits on Dec 4, 2024

• reverted changes for GroupSlot (extra fields are back), renamed value_format into string_format

  ZergLev

  committed
  4423850

• made string_format Optional[]

  ZergLev

  committed
  2794f8f

• moved ValueSlot before GroupSlot

  ZergLev

  committed
  a33a4f7

• changed RegexGroupSlot base class to BaseSlot

  ZergLev

  committed
  ce8f606

• fixed tests, they pass now

  ZergLev

  committed
  d9aa6b2

• added default_values to RegexpGroupSlot, fixed an issue with get_value, finished the RegexpGroupSlot test, fixed a weird Pydantic inheritance issue

  ZergLev

  committed
  b361ea0

Commits on Dec 11, 2024

• minor changes, lint, porting to laptop

  ZergLev

  committed
  7e4580a

• added the string_format test, added exception handling for string representation in ExtractedGroupSlot (SlotManager already does that, so I replicated that for coherence)

  ZergLev

  committed
  c53ffd1

• started tutorial for RegexpGroupSlot and string_format feature of GroupSlot

  ZergLev

  committed
  b254bd8

• fixed test for string_format, works now

  ZergLev

  committed
  89eee15

• added SlotValueEquals in test_slot_functions.py, this particular change needs to be reviewed

  ZergLev

  committed
  4534466

Commits on Dec 12, 2024

• small review done in meeting (reverted exception handling in GroupSlot, test#3 tweaked(SlotEqualsValue) ), added SlotEqualsValue condition to existing tutorial

  ZergLev

  committed
  729d449

Commits on Dec 13, 2024

• added docs for _flatten_group_slot

  ZergLev

  committed
  01731df

• lint + SlotEqualsValue condition fixed (tests pass now)

  ZergLev

  committed
  14cc4fd

• minor fix for doc building (title underscores added)

  ZergLev

  committed
  9890179

• Updating API reference

  ZergLev

  committed
  fc5bc58

• started the RegexpGroupSlot and string_format tutorial

  ZergLev

  committed
  4d9f790

Commits on Dec 16, 2024

• model_validator added for RegexpGroupSlot (checking that groups() dictionary doesn't request a capture group that's out of bounds)

  ZergLev

  committed
  41ef517

• fixed weird test bug, will discuss during call

  ZergLev

  committed
  575ad22