Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor revalidation #289

Merged
merged 84 commits into from
Apr 15, 2024
Merged

Actor revalidation #289

merged 84 commits into from
Apr 15, 2024

Conversation

pseusys
Copy link
Collaborator

@pseusys pseusys commented Nov 22, 2023

Description

Actor validation made required and also improved.

Checklist

  • I have performed a self-review of the changes
  • Run lint
  • Check all the tests + files for artifacts
  • Revise test actor (and maybe test pipeline)
  • Add docs to functions

To Consider

  • Add tests (if functionality is changed)
  • Update API reference / tutorials / guides
  • Update CONTRIBUTING.md (if devel workflow is changed)
  • Update .ignore files, scripts (such as lint), distribution manifest (if files are added/deleted)
  • Search for references to changed entities in the codebase

@pseusys pseusys added the enhancement New feature or request label Nov 22, 2023
@pseusys pseusys requested review from kudep and RLKRo November 22, 2023 10:16
@pseusys pseusys self-assigned this Nov 22, 2023
@RLKRo RLKRo changed the base branch from master to dev November 23, 2023 13:54
@pseusys pseusys marked this pull request as ready for review November 24, 2023 00:13
@RLKRo RLKRo requested a review from ruthenian8 November 27, 2023 15:16
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
@pseusys pseusys requested review from ruthenian8 and RLKRo December 5, 2023 00:25
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
dff/pipeline/pipeline/actor.py Outdated Show resolved Hide resolved
Copy link
Member

@RLKRo RLKRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

Only some small suggestions left.

dff/script/core/script.py Outdated Show resolved Hide resolved
dff/script/core/script.py Show resolved Hide resolved
dff/script/core/script.py Outdated Show resolved Hide resolved
dff/script/core/script.py Outdated Show resolved Hide resolved
@RLKRo RLKRo merged commit 5ccead1 into dev Apr 15, 2024
17 checks passed
@RLKRo RLKRo deleted the feat/actor_revalidation branch April 15, 2024 23:00
@RLKRo RLKRo mentioned this pull request Jul 3, 2024
6 tasks
RLKRo added a commit that referenced this pull request Jul 3, 2024
# Changelog

## General

- Framework renamed from DFF to Chatsky (#368)

## Features

- New `has_text` condition for asserting that specific text is contained
inside the last request (#335)
- Validation stage reworked.
`Pipeline.validation_stage`, `Pipeline.verbose` and `Context.validation`
fields are removed.
  Added new type for annotating labels `dff.script.ConstLabel` (#289)
- Functions `cnd.exact_match` and `check_happy_path` now accept both
`Message` and `str`.
The following are now equivalent: `exact_match(Message("text"))` ==
`exact_match("text")`
  (#337)
- CLIMessengerInterface moved to `messengers.console` (#328)
- Attachments reworked (#328):
- `Session`, `Command`, `Link`, `Button`, `Keyboard` and `Attachments`
classes removed, `Message.commands` field removed.
- Added `CallbackQuery`, `Contact`, `Invoice`, `Poll`, `Animation`,
`Sticker`, `VoiceMessage`, `VideoMessage` and `MediaGroup` classes.
  - Added attachment caching feature.
  - Added `has_callback_query` condition.
  - Removed `title` field from Data Attachments. Use `caption` instead.
- Telegram Messenger interface reworked (#328):
  - Now provides methods for attachment byte download.
- Added support for receiving attachment types as members of
`Message.attachments`. Others may be accessed via
`Message.original_message`.
- Added support for sending new attachment types (`Sticker`, `Poll`,
e.t.c.).
- Added support for extra options such as `disable_notification`,
`message_effect_id` or `caption`.
  - Telegram tutorials rewritten to reflect all the changes.
- Added slots that simplify the process of extracting arbitrary data
from user messages and accessing it later (#36):
  - New user guide and tutorials on slots

## Documentation

- Return PRE_RESPONSE_PROCESSING and PRE_TRANSITION_PROCESSING tutorials
- New telegram interface tutorials (#328)
- Slots user guide and tutorials (#36)

## Contrib

- Added `poe quick_test` to run tests that are not slow and do not
require docker (#344)
- `Context.framework_states` renamed to `Context.framework_data` and
made `Pydantic.BaseModel` (#359)
- Added `MessengerInterfaceWithAttachments` class (#328)
- Added tools for enabling json serialization via pickle (#328)
- Telegram tests made independent from telegram servers (#328)
- `wrap_sync_function_in_async` moved to `utils.devel` (#36)

# Checklist

- [x] I have performed a self-review of the changes
- [x] Rename repos (this; template; demo)
- [ ] Add new logo; change favicons in conf.py (this can be done later)
- [x] Create new PyPi project and update pypi token
- [ ] Create a new release
- [x] Make a new release on the
[final_dff_release](https://github.com/deeppavlov/dialog_flow_framework/tree/final_dff_release)
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants