-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API #253
Merged
Merged
Update API #253
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
a110e62
Move updates from merge/slots; ensure passing tests
ruthenian8 bd67607
move run_response from Node object to Actor object; execute response …
ruthenian8 12eed6e
update documentation && change the signature of processing-related ac…
ruthenian8 43533b5
remove overwrite_current_node_in_processing method
ruthenian8 bb42016
allow asynchronous condition functions
ruthenian8 039840b
merge branch 'dev'
ruthenian8 5dc75a1
update tutorial
ruthenian8 b274383
fix merge errors
RLKRo dda1bc0
make import absolute
RLKRo 2d63c03
Apply suggestions by @RLKRo
ruthenian8 e2d8377
Update actor & group removing context assignment statements
ruthenian8 5df3c55
test responses for None; use validate_label once
ruthenian8 34c7d1a
merge dev into feat/async_handlers
ruthenian8 6378aa5
return context from the 'pipeline' service group
ruthenian8 84947ec
update tutorial tests for script/core;
ruthenian8 4878de9
Remove random seed; use seed value of 42
ruthenian8 95a5459
Deprecate overwrite_current_node
ruthenian8 8b0db0c
update deprecation details
ruthenian8 3cb2b77
fix: try to resolve docs bug
ruthenian8 ed126ab
update docs
ruthenian8 82a8c32
Update signature typings
ruthenian8 2a39d80
revert tutorial changes
RLKRo 51a8624
remove overwrite_current_node_in_processing instead of deprecating
RLKRo 63ba0f7
remove most context returns; update docs and typing
RLKRo 7b44375
fix actor test
RLKRo 1afa571
codestyle
RLKRo 58fa9aa
add parallel processing test
RLKRo cd41155
make global/local/node conditions run sequentially
RLKRo 3c70317
Merge branch 'dev' into feat/async_handlers
RLKRo 74ea26d
replace args, kwargs with update_ctx_misc
RLKRo 223b284
codestyle
RLKRo ce3a8a2
fix typing
RLKRo 48b6934
line collapse
RLKRo d8075f0
rename function to fit inside code blocks
RLKRo 6e0307f
fix tutorial function signatures
RLKRo 1079a51
Merge branch 'dev' into feat/async_handlers
RLKRo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthenian8 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to make transition functions asynchronous as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave such methods as
get_previous_node
andget_next_node
synchronous for two reasons: