Feat/update guide #209
Merged
Feat/update guide #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RLKRo
requested changes
Sep 12, 2023
RLKRo
requested changes
Sep 27, 2023
RLKRo
requested changes
Oct 2, 2023
Comment on lines
283
to
284
| (Message(text="Hello!"), Message(text="Hi!")), | ||
| (Message(text="hi"), Message(text="Let's play ping-pong!")), |
There was a problem hiding this comment.
Maybe make it so that the start node expects "/start" and the greeting node expects "Hello!"?
So that the happy path would be:
(Message(text="/start"), Message(text="Hi!")),
(Message(text="Hello!"), Message(text="Let's play ping-pong!")),
(Message(text="Ping!"), Message(text="Pong!"))
And fallback response function would also have to be changed.
# Conflicts: # docs/source/user_guides/basic_conceptions.rst
RLKRo
approved these changes
Oct 16, 2023
RLKRo
added a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe here what changes are made and why. If this pull request fixes a GitHub issue, reference it.
Checklist