Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin: arm64: config: Enable HISI crypto acct drivers #529

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Dec 23, 2024

Enable HISI_SEC2 HISI_ZIP HISI_HPRE HISI_TRNG
CRYPTO_CURVE25519 selected by HISI_HPRE

Enable  HISI_SEC2 HISI_ZIP HISI_HPRE HISI_TRNG
CRYPTO_CURVE25519 selected by HISI_HPRE
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 配置项的修改

    • 在配置文件中,新增了几个与加密和硬件设备相关的配置项。这些配置项是否必要,以及它们是否与项目的需求相匹配,需要进一步确认。
  2. 移除的配置项

    • 移除了 CONFIG_CRYPTO_CURVE25519=m 配置项。如果这个配置项是必要的,那么移除它可能会导致功能上的缺失。需要确认是否有替代方案或者这个配置项是否确实不再需要。
  3. 新增的配置项

    • 新增了 CONFIG_CRYPTO_DEV_HISI_SEC2=mCONFIG_CRYPTO_DEV_HISI_ZIP=mCONFIG_CRYPTO_DEV_HISI_HPRE=mCONFIG_CRYPTO_DEV_HISI_TRNG=m 配置项。这些配置项是否与项目的硬件设备和加密需求相匹配,需要进一步确认。
  4. 注释掉的配置项

    • CONFIG_CRYPTO_DEV_AMLOGIC_GXL 配置项被注释掉了。如果这个配置项是必要的,那么需要将其取消注释,或者提供替代方案。
  5. 代码风格和一致性

    • 配置文件中的配置项应该保持一致的格式和风格,以便于维护和理解。例如,新增的配置项应该与现有的配置项对齐,并且保持一致的缩进。
  6. 文档和注释

    • 对于新增和修改的配置项,应该添加相应的文档和注释,说明这些配置项的作用和配置方法,以便其他开发者能够理解和使用。

综上所述,建议在合并这些更改之前,进行充分的测试和验证,确保这些配置项的正确性和必要性。同时,保持配置文件的一致性和可维护性,并添加必要的文档和注释。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff opsiff merged commit 64f7936 into linux-6.6.y Dec 23, 2024
7 of 10 checks passed
@opsiff opsiff deleted the opsiff-patch-hisi-crypto-config branch December 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants