Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin: arm64: config: Enable ftrace syscall #527

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

opsiff
Copy link
Member

@opsiff opsiff commented Dec 23, 2024

It has already enabled in x86 and loongarch config, it well used in some applications.
I don`t know why miss it, but we can directly enable it now.

@opsiff opsiff changed the title deepin: arm64: config: Enable Android binder drivers deepin: arm64: config: Enable ftrace syscall Dec 23, 2024
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It has already enabled in x86 and loongarch config,
it well used in some applications.
I don`t know why miss it, but we can directly enable it now.

Signed-off-by: Wentao Guan <[email protected]>
@opsiff opsiff force-pushed the opsiff-config-enabled-ftrace-syscall branch from 99ec610 to 8fe0fcc Compare December 23, 2024 07:39
@deepin-ci-robot
Copy link

deepin pr auto review

在提供的代码更改中,添加了 CONFIG_FTRACE_SYSCALLS=y 这一行。这个更改可能会影响系统的性能和安全性,因此需要进一步审查。

代码审查

  1. 配置项的添加

    • 添加了 CONFIG_FTRACE_SYSCALLS=y,这可能会启用内核的函数跟踪功能,从而记录系统调用。这可能会对系统性能产生一定影响,特别是在高负载情况下。
  2. 性能影响

    • 启用 CONFIG_FTRACE_SYSCALLS 可能会增加系统开销,因为它需要记录每个系统调用的详细信息。如果系统调用频繁,这可能会显著影响性能。
  3. 安全性考虑

    • 跟踪系统调用可能会暴露系统内部的信息,包括用户权限和系统调用参数。这可能会增加安全风险,特别是在敏感系统上。

改进建议

  1. 性能评估

    • 在启用 CONFIG_FTRACE_SYSCALLS 之前,应该进行性能测试,以评估其对系统性能的影响。如果影响较大,可以考虑在特定条件下启用,或者使用其他性能优化手段。
  2. 安全性评估

    • 在启用 CONFIG_FTRACE_SYSCALLS 之前,应该评估其对系统安全性的影响。如果存在潜在的安全风险,应该考虑使用其他安全机制来保护敏感信息。
  3. 配置管理

    • 如果决定启用 CONFIG_FTRACE_SYSCALLS,应该确保配置管理流程能够妥善处理这一变更,并确保所有相关人员都了解这一变更的影响。
  4. 文档更新

    • 如果添加了 CONFIG_FTRACE_SYSCALLS,应该更新相关文档,说明这一变更及其对系统性能和安全性可能产生的影响。

综上所述,虽然添加 CONFIG_FTRACE_SYSCALLS 可能是必要的,但需要仔细评估其对性能和安全性可能产生的影响,并采取相应的措施来确保系统的稳定性和安全性。

@opsiff opsiff merged commit 6145236 into linux-6.6.y Dec 23, 2024
6 of 10 checks passed
@opsiff opsiff deleted the opsiff-config-enabled-ftrace-syscall branch December 23, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants