Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin: arm64: config: Update arm64 desktop config #523

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Avenger-285714
Copy link
Collaborator

Follow changes:
*Update configs by "make savedefconfig"
*Change pstore_ram from y to m
*Disable zboot

Reported-by: Jie Fan [email protected]
Suggested-by: Wentao Guan [email protected]

Follow changes:
 *Update configs by "make savedefconfig"
 *Change pstore_ram from y to m
 *Disable zboot

Reported-by: Jie Fan <[email protected]>
Suggested-by: Wentao Guan <[email protected]>
Signed-off-by: WangYuli <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 移除不必要的配置项

    • 移除了 CONFIG_KERNEL_ZSTDCONFIG_Z3FOLDCONFIG_EFI_ZBOOTCONFIG_MXGBE_FIX_VF_QUEUECONFIG_MXGBE_FIX_MAC_PADDINGCONFIG_MXGBE_DCBCONFIG_MXGBEVF_FIX_VF_QUEUECONFIG_MXGBEVF_FIX_MAC_PADDINGCONFIG_PSTORE_RAM 的配置。这些配置项是否被移除是合理的,因为它们可能不再需要或者与当前的项目需求不相关。
  2. 配置项的修改

    • CONFIG_PSTORE_RAMy 修改为 m,这表示将 PSTORE_RAM 模块化。这是一个好的做法,因为它允许在需要时动态加载模块,而不是在内核启动时加载,从而节省内存资源。
  3. 注释掉的配置项

    • 注释掉了 CONFIG_MGBEVF_OPTM_WITH_LARGECONFIG_MXGBE_OPTM_WITH_LARGE,这可能是为了禁用某些优化选项,以避免潜在的性能问题或兼容性问题。如果这些配置项被禁用是经过充分测试的,那么这是合理的。
  4. 配置项的顺序

    • 配置项的顺序没有明显的问题,但建议保持一致的顺序,以便于维护和阅读。
  5. 代码风格和一致性

    • 代码风格和一致性方面,建议检查整个配置文件,确保所有配置项的格式和注释风格保持一致。
  6. 潜在的性能影响

    • 移除 CONFIG_Z3FOLD 可能会影响系统的性能,因为 Z3FOLD 是一个用于内存压缩的模块。如果移除这个模块会导致性能下降,那么需要重新评估这个改动。
  7. 安全性

    • 没有涉及到安全性的配置项,因此不需要特别关注。

总体来说,这些改动看起来是合理的,但需要确保这些配置项的移除不会对系统的功能或性能产生负面影响。如果可能的话,建议进行充分的测试来验证这些改动。

@Avenger-285714 Avenger-285714 requested review from MingcongBai, opsiff and winnscode and removed request for winnscode December 16, 2024 02:29
@opsiff opsiff merged commit 2995fc9 into deepin-community:linux-6.6.y Dec 16, 2024
3 of 5 checks passed
@opsiff
Copy link
Member

opsiff commented Dec 16, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants