Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phytium [Deepin Kernel SIG] ]net: macb: phytium-gem: donot convert the enum constant to a boolean #498

Merged

Conversation

Avenger-285714
Copy link
Collaborator

Fix follow error with clang-19:

drivers/net/ethernet/cadence/macb_main.c:724:71: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]
724 | if (macb_is_gem(bp) && (state->interface == PHY_INTERFACE_MODE_SGMII ||
| ^
1 error generated.

Fix follow error with clang-19:

drivers/net/ethernet/cadence/macb_main.c:724:71: error: converting the enum constant to a boolean [-Werror,-Wint-in-bool-context]
  724 |         if (macb_is_gem(bp) && (state->interface == PHY_INTERFACE_MODE_SGMII ||
      |                                                                              ^
1 error generated.

Signed-off-by: WangYuli <[email protected]>
@Avenger-285714 Avenger-285714 merged commit 08e335d into deepin-community:linux-6.6.y Nov 25, 2024
3 of 5 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码修改中,逻辑判断条件被简化,提高了代码的可读性。

是否建议立即修改:

  • 否,这次提交的修改没有引入新的问题,也没有改变原有的逻辑。因此,不需要立即进行修改。但是,建议进行进一步的代码审查以确保没有其他潜在的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from avenger-285714. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants