Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] x86/mce: Set bios_cmci_threshold for CMCI threshold #281

Merged

Conversation

leoliu-oc
Copy link
Contributor

zhaoxin inclusion
category: bugfix
CVE: NA


In the Linux kernel, the CMCI threshold is set to 1 by default. This patch prevents Linux from overwriting the CMCI threshold set by the bios. With this patch, the CMCI threshold can be set through the BIOS, which can also avoid CMCI storms, on Zhaoxin/Centaur CPUs.

zhaoxin inclusion
category: bugfix
CVE: NA

-----------------

In the Linux kernel, the CMCI threshold is set to 1 by default. This patch
prevents Linux from overwriting the CMCI threshold set by the bios. With
this patch, the CMCI threshold can be set through the BIOS, which can also
avoid CMCI storms, on Zhaoxin/Centaur CPUs.

Signed-off-by: leoliu-oc <[email protected]>
@deepin-ci-robot deepin-ci-robot requested review from BLumia and myml June 14, 2024 12:16
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opsiff
Copy link
Member

opsiff commented Jun 15, 2024

/ok-to-test

@opsiff
Copy link
Member

opsiff commented Jun 15, 2024

/lgtm

@opsiff opsiff merged commit 66015fc into deepin-community:linux-6.6.y Jun 15, 2024
3 of 5 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • __mcheck_cpu_apply_quirks函数中新增了mca_cfg.bios_cmci_threshold的赋值操作,但未提供上下文信息,无法判断是否合理。
  • 变量mca_cfg在函数中未定义,可能是一个全局变量,这可能导致潜在的命名冲突和内存管理问题。

是否建议立即修改:

  • 是,需要提供mca_cfg的定义和上下文信息,并确保代码的清晰性和可维护性。

@opsiff
Copy link
Member

opsiff commented Jun 15, 2024

意图上是不是类似于下面这个补丁,建议提交上游
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1f68ce2a027250aeeb1756391110cdc4dc97c797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants