Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux-6.6.y] cpufreq: ACPI: add ITMT support when CPPC enabled #273

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

leoliu-oc
Copy link
Contributor

The _CPC method can get per-core highest frequency.
The highest frequency may varies between cores which mean cores can running at different max frequency, so can use it as a core priority and give a hint to scheduler in order to put critical task to the higher priority core.

zhaoxin inclusion
category: bugfix

-------------------

The _CPC method can get per-core highest frequency.
The highest frequency may varies between cores which mean cores can
running at different max frequency, so can use it as a core priority
and give a hint to scheduler in order to put critical task to the
higher priority core.

Signed-off-by: leoliu-oc <[email protected]>
zhaoxin inclusion
category: feature

--------------------

Set ASYM_PACKING Flag on Zhaoxin KH-40000 platform

Signed-off-by: leoliu-oc <[email protected]>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opsiff
Copy link
Member

opsiff commented Jun 19, 2024

/ok-to-test
/lgtm

@opsiff opsiff merged commit 2c070ab into deepin-community:linux-6.6.y Jun 19, 2024
3 of 4 checks passed
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • cpufreq_set_itmt_prio函数中,对cppc_highest_perf_diff变量的使用可能存在逻辑错误,应该在if条件判断之后再进行赋值。
  • cpufreq_sched_itmt_work_fn函数中使用了schedule_work,但没有检查work是否为NULL,可能会导致空指针解引用的风险。
  • for_each_cpu宏在cpufreq_set_itmt_prio函数中被错误地用于遍历所有CPU,应该仅限于特定CPU架构和型号。
  • sched_set_itmt_supportsched_set_itmt_core_prio函数的导出符号被修改为GPL,但这两个函数本身并没有提供GPL兼容的实现。
  • get_max_boost_ratio函数在acpi_cpufreq_cpu_init中被调用,但没有提供相应的实现或注释说明其用途。
  • blacklisted变量在acpi_cpufreq_cpu_init函数中被声明但未使用,应该移除未使用的变量以提高代码清晰度。
  • for_each_cpu宏在acpi_cpufreq_cpu_init中被错误地用于遍历所有CPU,应该仅限于特定CPU架构和型号。
  • build_sched_domains函数中,对sd->flags的操作应该在sd不为NULL的前提下进行,以避免潜在的空指针解引用错误。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants