Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intel-SIG] MTL mei driver updates sync with upstream (6.9) #245

Merged
merged 10 commits into from
Jun 14, 2024
Prev Previous commit
Next Next commit
Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"
mainline:e3dc66d998d2b0c2734db9ca1d6c94c97349529a
severity: Moderate

upstream commit e3dc66d ("Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"")

This reverts commit 058a38a.

It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in
an interrupt handler as the interrupt handler itself would be called in a
process context if PREEMPT_RT is enabled. So revert the patch.

Intel-SIG: commit e3dc66d ("Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"")

Cc: [email protected] # for 6.8
Signed-off-by: Sakari Ailus <[email protected]>
Acked-by: Tomas Winkler <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
[ Quanxian Wang: amend commit log ]
Signed-off-by: Quanxian Wang <[email protected]>
  • Loading branch information
Sakari Ailus authored and quanxianwang committed May 30, 2024
commit 03ad3f929e6921b84549527c11248f7ebcbfc78b
4 changes: 2 additions & 2 deletions drivers/misc/mei/vsc-tp.c
Original file line number Diff line number Diff line change
@@ -419,15 +419,15 @@ static irqreturn_t vsc_tp_isr(int irq, void *data)

atomic_inc(&tp->assert_cnt);

wake_up(&tp->xfer_wait);

return IRQ_WAKE_THREAD;
}

static irqreturn_t vsc_tp_thread_isr(int irq, void *data)
{
struct vsc_tp *tp = data;

wake_up(&tp->xfer_wait);

if (tp->event_notify)
tp->event_notify(tp->event_notify_context);