Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(kernel-rolling) INTx: phytium: Add Phytium INTx driver support #208

Conversation

MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 27, 2024

Picked and rebased from #188.

From original pull request:

Driver for Phytium PCIe legacy INTx interrupt controller.

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MingcongBai MingcongBai changed the title (kernel-rolling) irqchip: phytium: Add Phytium INTx driver support (kernel-rolling) INTx: phytium: Add Phytium INTx driver support May 27, 2024
Driver for Phytium PCIe legacy INTx interrupt controller.

Signed-off-by: Chen Baozi <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: Tian Wei <[email protected]>
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-intx branch from ce60cac to 142bc73 Compare May 29, 2024 00:39
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_ixic_irq_eoi函数中,WARN_ON(intx >= NUM_IRQS)WARN_ON(nr_irqs != 1)应该被替换为更具体的错误信息,以便于调试。
  • phytium_ixic_translate函数中的if (is_of_node(fwspec->fwnode))检查可能不准确,因为fwspec->fwnode可能不是of_node类型。
  • phytium_ixic_alloc函数中的WARN_ON(nr_irqs != 1)检查可能不准确,因为nr_irqs可能不是1。
  • phytium_ixic_init函数中的of_address_to_resource函数调用可能会导致内存泄漏,因为如果解析资源失败,ctrhpb资源没有被正确释放。
  • phytium_ixic_dt_init函数中的iounmap调用应该在irq_domain_add_hierarchy成功后立即调用,以避免潜在的内存泄漏。
  • phytium_ixic_acpi_probe函数中的iounmap调用应该在acpi_irq_create_hierarchy成功后立即调用,以避免潜在的内存泄漏。
  • phytium_ixic_driver模块的builtin_platform_driver调用可能不适用于所有情况,应该考虑使用platform_driver宏。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants